Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exporter/datadogexporter: Graduate exporter.datadog.hostname.preview to stable. #20286

Merged
merged 5 commits into from
Mar 23, 2023
Merged

exporter/datadogexporter: Graduate exporter.datadog.hostname.preview to stable. #20286

merged 5 commits into from
Mar 23, 2023

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Mar 23, 2023

Description:
This PR graduates feature gate exporter.datadog.hostname.preview to Stable. This is a follow up to PR1 and PR2.

Note: This PR pins a pseudoversion of github.com/DataDog/datadog-agent/pkg/trace in order to take advantage of changes (commit) done in preparation of this PR. This pseudoversion also contains a change to add support for span links (PR), which has been added to the changelog.

@mackjmr
exporter/datadogexporter: Graduate exporter.datadog.hostname.preview …
0ad9b45 
…to stable.

This PR graduates feature gate `exporter.datadog.hostname.preview` to Stable. This is a follow up to [PR1](DataDog/opentelemetry-mapping-go#21) and [PR2](DataDog/datadog-agent#16159).

**Note:** This PR pins a pseudoversion of `github.com/DataDog/datadog-agent/pkg/trace` in order to use take advantage of changes ([commit](DataDog/datadog-agent@8b27e87)) done in preparation of this PR. This pseudoversion also contains a change to add support for span links ([PR](DataDog/datadog-agent#15767)), which has been added to the changelog.
@mackjmr mackjmr requested a review from a team March 23, 2023 13:29
@mackjmr mackjmr requested a review from mx-psi as a code owner March 23, 2023 13:29
@github-actions github-actions bot added the exporter/datadog Datadog components label Mar 23, 2023
@runforesight
Copy link

runforesight bot commented Mar 23, 2023 •
edited
Loading

Foresight Summary

    
Major Impacts

build-and-test-windows duration(22 seconds) has decreased 35 minutes 26 seconds compared to main branch avg(35 minutes 48 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 22 seconds (35 minutes 26 seconds less than main branch avg.) and finished at 23rd Mar, 2023.

Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 21 seconds and finished at 23rd Mar, 2023.

Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute 30 seconds and finished at 23rd Mar, 2023.

Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 23 seconds and finished at 23rd Mar, 2023.

Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  build-and-test workflow has finished in 35 minutes 51 seconds (16 minutes 10 seconds less than main branch avg.) and finished at 23rd Mar, 2023.

Job Failed Steps Tests
unittest-matrix (1.20, connector) -     🔗  ✅ 126  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, connector) -     🔗  ✅ 126  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) -     🔗  ✅ 583  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, internal) -     🔗  ✅ 583  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1557  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, processor) -     🔗  ✅ 1557  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 543  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, extension) -     🔗  ✅ 543  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2611  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, receiver-0) -     🔗  ✅ 2611  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, exporter) -     🔗  ✅ 2499  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2499  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, receiver-1) -     🔗  ✅ 1965  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1965  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, other) -     🔗  ✅ 4762  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4762  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
checks -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (connector) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.20) -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 41 seconds (3 minutes 5 seconds less than main branch avg.) and finished at 23rd Mar, 2023.

Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 7 minutes 24 seconds (4 minutes 29 seconds less than main branch avg.) and finished at 23rd Mar, 2023.

Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 14 minutes 43 seconds and finished at 23rd Mar, 2023.

Job Failed Steps Tests
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@mackjmr mackjmr requested a review from dmitryax as a code owner March 23, 2023 14:07
@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command labels Mar 23, 2023
@github-actions github-actions bot requested a review from pmcollins March 23, 2023 14:08
mx-psi
mx-psi reviewed Mar 23, 2023
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, just a nit on the release note (and a note about a future PR)

exporter/datadogexporter/metrics_exporter.go Show resolved Hide resolved
.chloggen/datadog-exporter-span-links-support.yaml Outdated Show resolved Hide resolved
@mx-psi mx-psi merged commit 4c570f2 into open-telemetry:main Mar 23, 2023
@codeboten codeboten added this to the next release milestone Mar 24, 2023
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this pull request Apr 17, 2023
@mackjmr
exporter/datadogexporter: update github.com/DataDog/datadog-agent/pkg…
8e97409 
…/trace.

This PR updates `github.com/DataDog/datadog-agent/pkg/trace` to `v0.45.0-rc.1`.

**Context:** The following [PR](open-telemetry#20286) had pinned a pseudoversion of `github.com/DataDog/datadog-agent/pkg/trace` (`v0.44.0-rc.4.0.20230322085447-8b27e87df01c`) which was required in order to take advantages of the following [commit](DataDog/datadog-agent@8b27e87).

This was later updated by Dependabot from `v0.44.0-rc.4.0.20230322085447-8b27e87df01c` to `0.44.0-rc.5` in this [PR](open-telemetry#20486). `0.44.0-rc.5` does not contain changes from the required [commit](DataDog/datadog-agent@8b27e87) (milestone `7.45.0`).

This PR now re-adds the changes back by updating to `v0.45.0-rc.1`.

Because the latest release contains `github.com/DataDog/datadog-agent/pkg/trace` `v0.44.0-rc.5`, which does not contain the changes from the following [commit](DataDog/datadog-agent@8b27e87), this brings two issues:
- the span links change was not added in the latest release, but it was added to the release notes => This PR adds a `bug_fix` changelog to indicate this.
- in the latest release, the hostname preview logic is off by default, instead of on by default (due to the removal of the following [setting](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/20286/files#diff-9ca998552699e406631ae1a165fef81d5373ba6876136c8c48c10ae0355edf2aL179) which only works in combination of the  required [commit](DataDog/datadog-agent@8b27e87)) => This PR adds a `bug_fix` changelog to indicate this.

It also adds the changelog related to [PR1](DataDog/datadog-agent#16337) and [PR2](DataDog/datadog-agent#16430), which are brought in from the upgrade to `v0.45.0-rc.1`.
@mackjmr mackjmr mentioned this pull request Apr 17, 2023
Merged
mx-psi pushed a commit that referenced this pull request Apr 17, 2023
@mackjmr @songy23
exporter/datadogexporter: update github.com/DataDog/datadog-agent/pkg…
db8208c 
…/trace. (#20923)

* exporter/datadogexporter: update github.com/DataDog/datadog-agent/pkg/trace.

This PR updates `github.com/DataDog/datadog-agent/pkg/trace` to `v0.45.0-rc.1`.

**Context:** The following [PR](#20286) had pinned a pseudoversion of `github.com/DataDog/datadog-agent/pkg/trace` (`v0.44.0-rc.4.0.20230322085447-8b27e87df01c`) which was required in order to take advantages of the following [commit](DataDog/datadog-agent@8b27e87).

This was later updated by Dependabot from `v0.44.0-rc.4.0.20230322085447-8b27e87df01c` to `0.44.0-rc.5` in this [PR](#20486). `0.44.0-rc.5` does not contain changes from the required [commit](DataDog/datadog-agent@8b27e87) (milestone `7.45.0`).

This PR now re-adds the changes back by updating to `v0.45.0-rc.1`.

Because the latest release contains `github.com/DataDog/datadog-agent/pkg/trace` `v0.44.0-rc.5`, which does not contain the changes from the following [commit](DataDog/datadog-agent@8b27e87), this brings two issues:
- the span links change was not added in the latest release, but it was added to the release notes => This PR adds a `bug_fix` changelog to indicate this.
- in the latest release, the hostname preview logic is off by default, instead of on by default (due to the removal of the following [setting](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/20286/files#diff-9ca998552699e406631ae1a165fef81d5373ba6876136c8c48c10ae0355edf2aL179) which only works in combination of the  required [commit](DataDog/datadog-agent@8b27e87)) => This PR adds a `bug_fix` changelog to indicate this.

It also adds the changelog related to [PR1](DataDog/datadog-agent#16337) and [PR2](DataDog/datadog-agent#16430), which are brought in from the upgrade to `v0.45.0-rc.1`.

* update wording

* add issue # to changelog

* Update .chloggen/datadog-semconv-1.17.yaml

Co-authored-by: Yang Song <[email protected]>

---------

Co-authored-by: Yang Song <[email protected]>
mackjmr added a commit to DataDog/opentelemetry-mapping-go that referenced this pull request Apr 21, 2023
@mackjmr
pkg/otlp/{attributes,metrics}: Remove deprecated hostname preview fun…
3bd167e 
…ctions.

The deprecated functions have been removed/replaced in the agent ([PR1](DataDog/datadog-agent#16159), [PR2](DataDog/datadog-agent#16541)) and the collector ([PR1](open-telemetry/opentelemetry-collector-contrib#20286), [PR2](open-telemetry/opentelemetry-collector-contrib#20872)).
@mackjmr mackjmr mentioned this pull request Apr 21, 2023
Merged
mackjmr added a commit to DataDog/opentelemetry-mapping-go that referenced this pull request Apr 24, 2023
@mackjmr
pkg/otlp/{attributes,metrics}: Remove deprecated hostname preview fun…
be76739 
…ctions. (#55)

* pkg/otlp/{attributes,metrics}: Remove deprecated hostname preview functions.

The deprecated functions have been removed/replaced in the agent ([PR1](DataDog/datadog-agent#16159), [PR2](DataDog/datadog-agent#16541)) and the collector ([PR1](open-telemetry/opentelemetry-collector-contrib#20286), [PR2](open-telemetry/opentelemetry-collector-contrib#20872)).

* add issue # to changelog

* add missing line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@gbbr gbbr Awaiting requested review from gbbr

@liustanley liustanley Awaiting requested review from liustanley

@songy23 songy23 Awaiting requested review from songy23 songy23 is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax

@pmcollins pmcollins Awaiting requested review from pmcollins

Assignees

@jpkrohling jpkrohling

Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/datadog Datadog components
Projects
None yet
Milestone
v0.75.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mackjmr @mx-psi @jpkrohling @codeboten